-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OS to Ubuntu 24.04 and ROOT to 6.32.04 #103
base: main
Are you sure you want to change the base?
Conversation
Now that the TS stuff is fixed, I'm looking at this again. I see in the log that
I dont know what |
I have never seen this before either. It may be caused by our custom runner at UMN shutting down? I'm not sure, you can try to see if it works after trying again. |
Ah I guess so Anyway, I'll re-try again |
There is precedence for not supporting older ldmx-sw versions with newer development container images; however, this is not enforced anywhere. Instead it is simply documented online: https://ldmx-software.github.io/developing/compatibility.html We could do something similar here. Cut a new major version of the development image and point out that you need to use a newer ldmx-sw with the newer development image.
Edit: nevermind, it looks like ldmx-sw just needs some patches after we update the compiler. This makes sense and has been required before. Similar to the linked documentation online, I'd like there to be some detail on why older ldmx-sw versions can't be compiled just in case someone wants to go backward. |
I thought about this a bit over the weekend and I have two more thoughts. I would really like to keep the CI testing back to v4.0 at least, so I would request that you focus on figuring out the necessary patch for v4.0.0 (the easiest case is that its the same patch necessary to get I don't like how I originally implemented by backport solution (basically just using |
I am adding a new package to the container, here are the details.
Resolves #102
What new packages does this PR add to the development container?
Check List
works nicely.
This fails, but with the problem already known in LDMX-Software/ldmx-sw#1470
Accept that now even with the minimal compiler settings it fails.
--> So I'm blocked here