use IfElse.jl for Julia 1.6" #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 92.37% 94.62% +2.24%
==========================================
Files 10 10
Lines 748 818 +70
==========================================
+ Hits 691 774 +83
+ Misses 57 44 -13
☔ View full report in Codecov by Sentry. |
exaexa
requested changes
Aug 6, 2023
| @@ -7,7 +7,7 @@ function sbmlPiecewise(args...) | |||
| elseif length(args) >= 3 | |||
| IfElse.ifelse(args[2], args[1], sbmlPiecewise(args[3:end]...)) | |||
| else | |||
| throw(DomainError(args, "malformed piecewise SBML function")) | |||
| IfElse.ifelse(args[2], args[1], NaN) | |||
There was a problem hiding this comment.
this could work but we need an user-supplied "bottom" value instead of the NaN here.
Does IfElse have anything like that?
There was a problem hiding this comment.
Not that I am aware of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could imagine that #251 fails on Julia 1.6, because it requires IfElse.jl. Let's see if CI passes for this.