Feature/add nix #26
Merged
Feature/add nix #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 2, 2024 23:36
LTDakin
approved these changes
Aug 23, 2024
LTDakin
reviewed
Aug 23, 2024
k8s/base/deploy-static.yaml
Outdated
| optional: false | ||
| - secretRef: | ||
| name: env | ||
| optional: false |
There was a problem hiding this comment.
don't exactly know what these are, but remembered Matt told me to fix them one time
There was a problem hiding this comment.
yeah, newline at end of file as defined by the POSIX standard. See SO answer for explanation: https://stackoverflow.com/a/729795
mgdaily
approved these changes
Aug 23, 2024
jashan-lco
reviewed
Aug 27, 2024
| apiVersion: skaffold/v4beta10 | ||
| kind: Config | ||
| metadata: | ||
| name: app-image |
There was a problem hiding this comment.
You don't really need to separate out the build spec into a separate module. It could be merged into the app module. The reason I did it for the obs-portal, because I wanted to be able to use just that bit from another remote skaffold module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put instructions in the readme with steps that should be able to get you running locally for development. I have a set of secrets.env that I can share through slack or something to connect to the dev S3 bucket I created and to the production obs portal as a client app for user login.
My thoughts were we would connect to production archive/obs portal for accounts and to get the latest images to work with since dev archive doesn't have images added to it regularly. But the S3 bucket is a dev bucket, and nothing should be writing to the obs portal or archive so it should be relatively safe. The caveat is right now an archive api token is needed, but users can just use their own which will have permissions to see whatever files they can see in their accounts when they login, which should be fine for local testing.