Updates from review comments

.gitignore

@@ -36,6 +36,9 @@ MANIFEST
 pip-log.txt
 pip-delete-this-directory.txt
 
+# Local dev secrets
+k8s/envs/local/secrets.env
+
 # Unit test / coverage reports
 htmlcov/
 .tox/

README.md

@@ -42,14 +42,11 @@ Now start your server
 ### Nix development
 For this mode of development, you must install:
 -   nix with flakes support
--   kind
--   skaffold
 
 Then to develop, run these commands:
 -   `nix develop --impure` to start your nix development environment - **called anytime you use a new terminal**
--   `kind create cluster --config ./local-cluster.yaml` to create the cluster - **should only need to be called one time within the nix environment**
 -   `ctlptl apply -f local-registry.yaml -f local-cluster.yaml` to start up the registry and cluster - **should only need to be called one time within the nix environment**
--   `skaffold dev -m deps` to start the dependencies - **run this in a different tab to keep running during development**
+-   `skaffold dev -m deps` to start the dependencies - **run this in a different tab to keep running during development or use 'run' instead of 'dev'**
 -   configure the `./k8s/envs/local/secrets.env` values for connecting to the appropriate services.
 -   `skaffold dev -m app --port-forward` to start the servers and worker. This will auto-redeploy as you make changes to the code.
 

k8s/base/deploy-static.yaml

@@ -128,4 +128,4 @@ spec:
                 optional: false
             - secretRef:
                 name: env
-                optional: false
+                optional: false

k8s/base/deploy-worker.yaml

@@ -19,8 +19,9 @@ spec:
         fsGroup: 1000
       volumes:
         - name: tmp
-          persistentVolumeClaim:
-            claimName: worker-tmp-pvc
+          emptyDir:
+            medium: Memory
+            sizeLimit: 1Gi
       containers:
         - name: default
           image: datalab

k8s/base/kustomization.yaml

@@ -6,8 +6,6 @@ resources:
   - ./svc-server.yaml
   - ./deploy-static.yaml
   - ./svc-static.yaml
-  - ./pv.yaml
-  - ./pvc.yaml
   - ./deploy-worker.yaml
 
 labels:

k8s/base/svc-static.yaml

@@ -13,4 +13,4 @@ spec:
   ports:
     - name: static
       port: 80
-      targetPort: static
+      targetPort: static

k8s/envs/local/ns.yaml

@@ -1,4 +1,4 @@
 apiVersion: v1
 kind: Namespace
 metadata:
-  name: datalab
+  name: datalab

k8s/envs/local/secrets.env → k8s/envs/local/secrets.env.changeme

@@ -5,4 +5,4 @@ OAUTH_CLIENT_ID=changeme
 OAUTH_CLIENT_SECRET=changeme
 ARCHIVE_API_TOKEN=changeme
 AWS_ACCESS_KEY_ID=changeme
-AWS_SECRET_ACCESS_KEY=changeme
+AWS_SECRET_ACCESS_KEY=changeme