Feature/calendar #86
Merged
Feature/calendar #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnation3406
approved these changes
Nov 12, 2024
| @@ -28,7 +29,7 @@ | |||
| "pinia-plugin-persistedstate": "^3.2.1", | |||
| "sass": "^1.75.0", | |||
| "sass-loader": "^14.2.1", | |||
| "v-calendar": "^3.1.2", | |||
| "v-calendar": "^3.0.0", | |||
There was a problem hiding this comment.
Did they remove the date range functionality in newer versions or something?
There was a problem hiding this comment.
yeah there's a bug in 3.1.2
There was a problem hiding this comment.
I'm looking through my history to try to find the github issue but basically the bug didn't take max-date into consideration
| @@ -196,15 +199,6 @@ async function getAvailableTimes () { | |||
| }) | |||
| } | |||
|
|
|||
| // Used to block out dates that are not in the availableTimes object from the date picker | |||
| const isDateAllowed = (date) => { | |||
There was a problem hiding this comment.
Is this logic of blocking out dates reimplemented somewhere else now?
There was a problem hiding this comment.
I guess I figured out that the availableTimes were today --> one week from now and that's in the min-date and max-date props. But maybe it's safer to keep this logic
mgdaily
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE/FIX: Using same calendar when booking RTI and requesting observations
Background:
More than one style of calendar was being used and that was because I couldn't find a date picker and a date range picker but now I've found an older version of a package and it works well.
Implementation:
main.jsTimePicker(that one was pretty simple, not much changed)BeginnerSchedulingandAdvancedSchedulingbecause the componentVDatePickercontains the object keys ofstartandendfrom the package.calendarUtilsbut have to discuss with Edward how these should be used. Basically, this gets the start and end dates of the current semester and its purpose is meant to set limitsVISUALS
Calendar when booking for RTI
Calendar when requesting a scheduled observation (end of current semester is Jan 31)
Screen.Recording.2024-11-12.at.1.41.08.PM.mov