-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/mygallery component #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I feel like I understand component testing a bit more now.
package.json
Outdated
@@ -15,9 +15,11 @@ | |||
"@fortawesome/free-solid-svg-icons": "^6.5.2", | |||
"@fortawesome/pro-regular-svg-icons": "^6.6.0", | |||
"@fortawesome/vue-fontawesome": "^3.0.6", | |||
"@vitejs/plugin-vue": "^5.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be a dev dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, probably should be
package.json
Outdated
@@ -15,9 +15,11 @@ | |||
"@fortawesome/free-solid-svg-icons": "^6.5.2", | |||
"@fortawesome/pro-regular-svg-icons": "^6.6.0", | |||
"@fortawesome/vue-fontawesome": "^3.0.6", | |||
"@vitejs/plugin-vue": "^5.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, probably should be
TEST:
MyGallery
integration testThis test tests the way the component handles the api calls and how it handles the responses. I remount the component in every test so that there's no cross contamination between tests. In other words, to reset the state to a blank slate.
Here are the tests that I'm running