Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: update base svc pkg to avoid merge bug downstream #108

Merged
merged 1 commit into from
Dec 16, 2024
Merged

k8s: update base svc pkg to avoid merge bug downstream #108

merged 1 commit into from
Dec 16, 2024

Conversation

jashan-lco
Copy link
Contributor

No description provided.

@jashan-lco
Copy link
Contributor Author

jashan-lco commented Dec 16, 2024 •
edited
Loading

Turns out kpt pkg update does a recursive update. The service package changed significantly since the original clone
(in a backwards in compatible way), leading to a bad merge of YAML lists. This is what causes that extra port to appear.

Long term I need to figure out a more straight forward way of just copying the k8s/base directory in our CI/CD pipeline, but this should fix the issue for the time being.

@mgdaily @capetillo

@jashan-lco jashan-lco merged commit f01f13a into main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgdaily mgdaily mgdaily approved these changes

@capetillo capetillo Awaiting requested review from capetillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jashan-lco @mgdaily