Update/populateinstruments #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdaily
reviewed
Dec 11, 2024
| }) | ||
| const filterList = [] | ||
| Object.values(response).forEach((instrument) => { | ||
| if (instrument.class === '0m4' && instrument.optical_elements.filters) { |
There was a problem hiding this comment.
this is probably fine for now, but if Wayne's telescopes are integrated they may be 0m35 or something different, and we generally would want to keep this easily adjustable. You could put it in a global at the top of the file, or read it from the public/config/config.json which we can set in the deployment at runtime!
There was a problem hiding this comment.
I'm intrigued by this read it from the public/config/config.json which we can set in the deployment at runtime. I'll be declaring it as a global config and ask you about that statement in person (or you can also explain here but I'm patient and willing to rewrite this when the time comes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: Populate instruments utils function
Background:
I was making two separate requests to two separate apis to get the instruments list for two separate components. Now it's a utils function and makes the request to the
instrumentsendpoint of the observation portal.Implementation:
Same as before, go through each value of the response and filter for only
0m4class that have filters and are schedulable.VISUALS:
Screenshot of filter list populating like before