Updates to fitting for faint traces. #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchate6
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our trace fitting algorithm to better deal with faint (read low signal-to-noise) traces. To fit the center, we take 25 pixel steps and fit the entire 25-pixel wide block using a match filter to get the trace center. We have also included error bars in the centroids estimated from this. These steps are fit to a Legendre polynomial to get initial coefficient guesses. We then fit the entire trace simultaneously (with a fixed width) to get the centers of the trace. Once we have the centers, we fix them and allow the width to vary. We include a background term that is a Legendre polynomial but the coefficients vary smoothly across the image.