Prefer same block/proposal for calibrations. Only use public calibrations. Use calibrations with the same slit width (i.e. same slit mask) for processing. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Use calibrations with the same slit width (i.e. same slit mask) for processing.
|
the tests seem awfully unhappy... :( |
jchate6
reviewed
Dec 11, 2024
sfoale
reviewed
Dec 12, 2024
setup.cfg
Outdated
| @@ -20,7 +20,7 @@ setup_requires = | |||
| psycopg2-binary | |||
| install_requires = | |||
| astropy >= 4.3 | |||
| banzai @ git+https://github.com/lcogt/banzai.git@1.19.1 | |||
| banzai @ git+https://github.com/lcogt/banzai.git@cals-by-block.git | |||
jchate6
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in the changes from LCOGT/banzai#403 to prefer calibrations from the same block or the same proposal. We now also only use public arcs if there is not one in the same block/proposal. This also adds a delay to processing if the observing block is still in progress so that we can use the calibrations taken at the end of the block.
We also only use arcs and flats taken with the same slit width.