Fix bug in the sorting

Kyon147 · Apr 25, 2022 · ab3cc7f · ab3cc7f
1 parent e7efcec
commit ab3cc7f
Show file tree

Hide file tree

Showing 4 changed files with 4,379 additions and 10 deletions.
diff --git a/lib/polaris-vue.css b/lib/polaris-vue.css
diff --git a/lib/polaris-vue.js b/lib/polaris-vue.js
@@ -2861,9 +2861,11 @@ exports.default = {
         cellContentTypeClass: function cellContentTypeClass(index) {
             return this.columnContentTypes && this.columnContentTypes[index] ? 'Polaris-DataTable__Cell--' + this.columnContentTypes[index] : '';
         },
-        handleOnSort: function handleOnSort(index, direction) {
+        handleOnSort: function handleOnSort(index) {
             var _this = this;
 
+            var direction = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : null;
+
             if (typeof index !== 'undefined' && this.sortable[index] === false) {
                 return;
             }
@@ -10077,10 +10079,7 @@ var render = function() {
                       attrs: { scope: "col" },
                       on: {
                         click: function($event) {
-                          return _vm.handleOnSort(
-                            index,
-                            _vm.defaultSortDirection
-                          )
+                          return _vm.handleOnSort(index)
                         }
                       }
                     },

diff --git a/lib/polaris-vue.js.map b/lib/polaris-vue.js.map
diff --git a/src/components/PolarisDataTable.vue b/src/components/PolarisDataTable.vue
@@ -17,7 +17,7 @@
                             ]"
                             class="Polaris-DataTable__Cell Polaris-DataTable__Cell--header"
                             scope="col"
-                            @click="handleOnSort(index, defaultSortDirection)"
+                            @click="handleOnSort(index)"
                         >
                             <div class="Polaris-DataTable__Heading">
                                 <span class="Polaris-DataTable__Icon">
@@ -216,7 +216,7 @@ export default {
         cellContentTypeClass(index) {
             return this.columnContentTypes && this.columnContentTypes[index] ? 'Polaris-DataTable__Cell--' + this.columnContentTypes[index] : ''
         },
-        handleOnSort(index, direction) {
+        handleOnSort(index, direction = null) {
             if (typeof index !== 'undefined' && this.sortable[index] === false) {
                 return
             }
@@ -225,7 +225,7 @@ export default {
             // If we have a specific direction set (like on load) then use that.
             if(direction){
                 this.sortedDirection = direction
-            }else if (this.sortedIndex === index){
+            } else if (this.sortedIndex === index){
                 // If we already have an index match then we need to flip the direction.
                 this.sortedDirection = this.sortedDirection === 'ascending' ? 'descending' : 'ascending'
             } else {