Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rest with graphql in the access scope query, add cache #359

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

enmaboya
Copy link
Contributor

@enmaboya enmaboya commented Oct 30, 2024

Access scopes are not something that change every day, so I don't see the point in making a request each time.

As for replacing REST with GraphQL, REST is already deprecated.

@enmaboya enmaboya force-pushed the replace_rest_with_graphql branch from 009b4c7 to 5b0477e Compare October 30, 2024 10:34
@enmaboya enmaboya changed the title replace rest with graphql in the access scope query, add cache Replace rest with graphql in the access scope query, add cache Oct 30, 2024
@enmaboya enmaboya force-pushed the replace_rest_with_graphql branch from 5b0477e to 7c26024 Compare October 30, 2024 10:38
Copy link
Owner

@Kyon147 Kyon147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, i'll merge it in for the next release

@Kyon147 Kyon147 merged commit 4f360b0 into Kyon147:master Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants