Update AppUninstalledJob.php #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
null guard against an invalid shop on uninstall
|
Thanks for the PR - i'll take a look this week. |
Kyon147
requested changes
Nov 7, 2023
Kyon147
approved these changes
Nov 7, 2023
|
@andreybutov there are some failing checks - can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null guard against an invalid shop on uninstall
We had a situation in dev where Shopify sent a bunch of uninstall webhook requests in bursts. This resulted in a state where the $shop returned from getByDomain(...) was null, resulting in an error being thrown. This is a simple guard against that null. I'm not super familiar with the package, so if there's cleanup to be done before returning, or if there's a better way to handle this, by all means.