#11217 fix substring function in calcite query enginr #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiezouSH
force-pushed
the
kap.11217
branch
2 times, most recently
from
a24413d to
fb0046d
Compare
vaful
approved these changes
Mar 29, 2019
eventd
suggested changes
Apr 2, 2019
| @@ -133,11 +133,21 @@ private SqlFunctions() { | |||
|
|
|||
| /** SQL SUBSTRING(string FROM ... FOR ...) function. */ | |||
| // override | |||
| public static String substring(String s, int from, int for_) { | |||
| if (s == null) { | |||
| public static String substring(String c, int s, int l) { | |||
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11217 fix substring function in calcite query engine