This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Convert Employee Commands to CSharpFunctionalExtensions #141
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| using System.Threading; | ||
| using CSharpFunctionalExtensions; | ||
|
|
||
| namespace PayrollProcessor.Core.Domain.Intrastructure.Operations.Commands; | ||
| public interface IStranglerCommandDispatcher | ||
| { | ||
| Result Dispatch(ICommand command, CancellationToken token = default); | ||
|
|
||
| Result<TResponse> Dispatch<TResponse>(ICommand<TResponse> command, CancellationToken token = default); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| using System.Threading; | ||
| using CSharpFunctionalExtensions; | ||
|
|
||
| namespace PayrollProcessor.Core.Domain.Intrastructure.Operations.Commands; | ||
| public interface IStranglerCommandHandler<TCommand> where TCommand : ICommand | ||
| { | ||
| Result Execute(TCommand command, CancellationToken token); | ||
| } | ||
|
|
||
| public interface IStranglerCommandHandler<TCommand, TResponse> where TCommand : ICommand<TResponse> | ||
| { | ||
| Result<TResponse> Execute(TCommand command, CancellationToken token); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| using System; | ||
| using System.Collections.Concurrent; | ||
| using System.Threading; | ||
| using Ardalis.GuardClauses; | ||
| using CSharpFunctionalExtensions; | ||
| using PayrollProcessor.Core.Domain.Intrastructure.Operations.Factories; | ||
|
|
||
| namespace PayrollProcessor.Core.Domain.Intrastructure.Operations.Commands; | ||
|
|
||
| /// <summary> | ||
| /// TODO: Temporarily named after the Strangler Fig Pattern as this serves as an implementation of <see cref="ICommandDispatcher"/> migrating to CSharpFunctionalExtensions from LanguageExt. | ||
|
There was a problem hiding this comment. Have you done this kind of naming in a project before? I haven't but I like the idea of calling this type out explicitly. That way, you know it should eventually be renamed when it takes over. There was a problem hiding this comment. I haven't done this before but the approach was mentioned in Code That Fits In Your Head and I couldn't think of a better name so I figured calling it out explicitly would be best while the code is in migration state. |
||
| /// </summary> | ||
| public class StranglerCommandDispatcher : IStranglerCommandDispatcher | ||
| { | ||
| private readonly ServiceProviderDelegate serviceProvider; | ||
| private static readonly ConcurrentDictionary<Type, object> commandHandlers = new ConcurrentDictionary<Type, object>(); | ||
|
|
||
| public StranglerCommandDispatcher(ServiceProviderDelegate serviceProvider) | ||
| { | ||
| Guard.Against.Null(serviceProvider, nameof(serviceProvider)); | ||
|
|
||
| this.serviceProvider = serviceProvider; | ||
| } | ||
|
|
||
| public Result Dispatch(ICommand command, CancellationToken token = default) | ||
| { | ||
| Guard.Against.Null(command, nameof(command)); | ||
|
|
||
| var commandType = command.GetType(); | ||
|
|
||
| var handler = (StranglerCommandHandlerWrapper)commandHandlers | ||
| .GetOrAdd( | ||
| commandType, | ||
| #pragma warning disable CS8603 // Possible null reference return. | ||
| t => Activator | ||
| .CreateInstance(typeof(StranglerCommandHandlerWrapperImpl<>) | ||
| .MakeGenericType(commandType))); | ||
| #pragma warning restore CS8603 // Possible null reference return. | ||
|
|
||
| return handler.Dispatch(command, serviceProvider, token); | ||
| } | ||
|
|
||
| public Result<TResponse> Dispatch<TResponse>(ICommand<TResponse> command, CancellationToken token = default) | ||
| { | ||
| Guard.Against.Null(command, nameof(command)); | ||
|
|
||
| var commandType = command.GetType(); | ||
|
|
||
| var handler = (StranglerCommandHandlerWrapper<TResponse>)commandHandlers | ||
| .GetOrAdd( | ||
| commandType, | ||
| #pragma warning disable CS8603 // Possible null reference return. | ||
| t => Activator | ||
| .CreateInstance(typeof(StranglerCreateCommandHandlerWrapperImpl<,>) | ||
| .MakeGenericType(commandType, typeof(TResponse)))); | ||
| #pragma warning restore CS8603 // Possible null reference return. | ||
|
|
||
| return handler.Dispatch(command, serviceProvider, token); | ||
| } | ||
| } | ||
|
|
||
| internal abstract class StranglerCommandHandlerWrapper : HandlerBase | ||
| { | ||
| public abstract Result Dispatch(ICommand command, ServiceProviderDelegate serviceProvider, CancellationToken token); | ||
| } | ||
|
|
||
| internal class StranglerCommandHandlerWrapperImpl<TCommand> : StranglerCommandHandlerWrapper | ||
| where TCommand : ICommand | ||
| { | ||
| public override Result Dispatch(ICommand command, ServiceProviderDelegate serviceProvider, CancellationToken token) => | ||
| GetHandler<IStranglerCommandHandler<TCommand>>(serviceProvider).Execute((TCommand)command, token); | ||
| } | ||
|
|
||
| internal abstract class StranglerCommandHandlerWrapper<TResponse> : HandlerBase | ||
| { | ||
| public abstract Result<TResponse> Dispatch(ICommand<TResponse> command, ServiceProviderDelegate serviceProvider, CancellationToken token); | ||
| } | ||
|
|
||
| internal class StranglerCreateCommandHandlerWrapperImpl<TCommand, TResponse> : StranglerCommandHandlerWrapper<TResponse> | ||
| where TCommand : ICommand<TResponse> | ||
| { | ||
| public override Result<TResponse> Dispatch(ICommand<TResponse> command, ServiceProviderDelegate serviceProvider, CancellationToken token) => | ||
| GetHandler<IStranglerCommandHandler<TCommand, TResponse>>(serviceProvider).Execute((TCommand)command, token); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍