add univ2 InitPoolSimulator to allow caller to re-use sim instance #330
+233
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuvo
reviewed
Jan 25, 2024
| const NUM_TOKEN = 2 | ||
|
|
||
| func InitPoolSimulator(entityPool entity.Pool, sim *PoolSimulator) error { | ||
| if len(entityPool.Tokens) != NUM_TOKEN || len(entityPool.Reserves) != NUM_TOKEN { |
There was a problem hiding this comment.
just be cautious, we should do nil check with sim here
There was a problem hiding this comment.
Thanks! 've added a check below
phqb
reviewed
Jan 26, 2024
Comment on lines
+84
to
+87
| var extra Extra | ||
| if err := json.Unmarshal([]byte(entityPool.Extra), &extra); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
yes we could (by putting Extra into the sim struct), but in this case it's quite small so I skipped it (so that I don't have to change NewPoolSimulator v1)
(this case is quite annoying, extra only used inside this function and nothing refer to it after that, but somehow the compiler still decided to moved it to heap instead, the heap analysis show the reason is the json.Unmarshal call, but I'm still not sure why)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InitPoolSimulatortake in an instance of pool simulator and fill it instead of allocating new oneBenchmark:
Allocating new simulator every time:
BenchmarkNewPoolSimulator-8 2421100 485.7 ns/op 464 B/op 13 allocs/opBest case: always re-use the same simulator:
BenchmarkNewPoolSimulatorV2-8 8776808 135.8 ns/op 48 B/op 2 allocs/opWhy did we need it?
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):