🧩 ERC-7412 Support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmonte
approved these changes
Oct 4, 2023
tommyrharper
reviewed
Oct 4, 2023
| @@ -11,4 +11,7 @@ contract OptimismParameters { | |||
| 0xb2F30A7C980f052f02563fb518dcc39e6bf38175; | |||
|
|
|||
| address public constant PYTH = 0xff1a0f4744e8582DF1aE09D5611b887B6a12925C; | |||
|
|
|||
| /// @custom:todo Optimism doesn't have a trusted forwarder yet | |||
| address public constant TRUSTED_FORWARDER = address(0); | |||
There was a problem hiding this comment.
Question: Are we not going to use this contract yet then? We will just wait until the trusted forwarder is deployed on OP before we deploy our new SMv3?
There was a problem hiding this comment.
We will wait until the trusted forwarder is on OP before deploying
|
One thing I am not clear on (separate to this PR) is how the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support calls to
ERC-7412.fulfillOracleQueryfunction from the SMv3 EngineDescription
EIP7412.solERC2771ContexttoEngine.solmsg.senderwithERC2771Context._msgSender()_trustedForwarderparameter to theEngine.constructorEIP7412.sol.env-example(PRIVATE_KEY must now start with0xelse parsing will fail within deploy script)Related issue(s)
N/A
Motivation and Context
These changes are required to interact with Synthetix Perps v3 after it adopted ERC-7412