Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weth unwrapper #57

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Weth unwrapper #57

merged 14 commits into from
Dec 13, 2024

Conversation

cmontecoding
Copy link
Contributor

Description

  • Create and test Pay.sol which allows the engine to no longer be payable, this helps with unwrapping WETH

Motivation and Context

The engine was payable to be able to unwrap WETH. This felt dangerous or at least allowed a lot more surface area.

JaredBorders
JaredBorders approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@JaredBorders JaredBorders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor comments that aren't PR blockers. Address them at your discretion, and once done, the code is GTG

Nice work! 💪

script/Deploy.s.sol Outdated Show resolved Hide resolved
src/Engine.sol Show resolved Hide resolved
src/utils/Pay.sol Outdated Show resolved Hide resolved
test/Pay.t.sol Outdated Show resolved Hide resolved
@cmontecoding cmontecoding merged commit dbc049f into base-multicollateral Dec 13, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredBorders JaredBorders JaredBorders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmontecoding @JaredBorders