Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum release zap #49

Merged
merged 177 commits into from
Oct 25, 2024
Merged

Arbitrum release zap #49

merged 177 commits into from
Oct 25, 2024

Conversation

Flocqst
Copy link
Contributor

@Flocqst Flocqst commented Sep 13, 2024

No description provided.

Flocqst and others added 30 commits September 13, 2024 16:23
@Flocqst
👷 Use updated zap contract
b33395f
@Flocqst
👷 Update interfaces
95e6283
@Flocqst
👷 Update Engine with new Zap contract and functionnalities
7d69349
@Flocqst
⚙ change optimizer_runs value
cf8bbf3
@Flocqst
✅ adjust to new zap contract
abbc856
@Flocqst
🚀 deploy arbitrum sepolia with updated zap
85a6d02
@Flocqst
👷 Add wrapModifyCollateralZap
e82c71e
@Flocqst
🚀 deploy arbitrum sepolia
26cce14
@Flocqst
👷 Add zap collateral approval
6611439
@Flocqst
👷 Zap flow approval
41f338b
@Flocqst
🚀 deploy arbitrum sepolia
3f8c81a
@Flocqst
👷 Rename modifyCollateralWrap
7ad5d12
@Flocqst
🚀 deploy arbitrum mainnet test engine
fe9e9fa
@Flocqst
🚀 deploy arbitrum sepolia
eb3f357
@Flocqst
👷 Add latest Zap contract
f9e8f6f
@Flocqst
👷 Adjust Engine to latest zap contract
f8d373c
@Flocqst
✅ Adjust to new Engine constructor
642bebf
@Flocqst
👷 latest Zap contract
8a08a01
@Flocqst
🚀 deploy arbitrum mainnet test engine
62e4c07
@Flocqst
👷 Add payDebt and modifyCollateralETH
47c7a50
@Flocqst
✅ Adjust to new Engine constructor
9c0675e
@Flocqst
🚀 deploy arbitrum mainnet test engine
e4707d4
@Flocqst
👷 use PERPS_MARKET_PROXY.payDebt
f919318
@Flocqst
🚀 deploy arbitrum mainnet test engine
59f59d7
@jcmonte
add approval
816025f
@jcmonte
remove negative casting as we are doing a withdrawal
8b50cd4
@Flocqst
👷 pull latest zap contract
2b8989c
@Flocqst
👷 rename to swapWith
9dcfcb0
@Flocqst
🚀 deploy arbitrum mainnet test engine
608e46c
@Flocqst
🚀 deploy arbitrum sepolia
dcf4178
@cmontecoding
Copy link
Contributor

i would like to see a couple more tests for the new depositCollateralETH change (auth and fuzz the difference of amount and msg.value)

also it looks like we just added access control to the unwind functions. we will need tests for those too

unwind auth tests are now done here
2b70360

cmontecoding and others added 26 commits October 21, 2024 15:48
@cmontecoding
✅ MulticallerWithSenderTest
d999321
@cmontecoding
✅ MulticallerWithSenderEngine asserts and constants
189711f
@Flocqst
Merge pull request #54 from Kwenta/multicall
9b95b85 
MulticallWithSender
@Flocqst
👷 pull final zap version
317be7d
@Flocqst
⚙ update foundry config
1790ddb
@Flocqst
✅ @Custom:todo finalize unwind test
0d8cdf5
@Flocqst
🚀 Synthetix Zap deployment
35560c8
@Flocqst
🚀 change pDAO parameter
7bd0421
@Flocqst
👷 update engine proxy address
8cef910
@Flocqst
🚀 deploy smv3 arb engine
86cb3ab
@Flocqst
🚀 Arb sepolia Zap deployment
b37b5a8
@Flocqst
🚀 Arb sepolia Zap deployment
96a7bb1
@Flocqst
🚀 deploy smv3 arb sepolia engine
6f5a767
@cmontecoding
✅📚 add new block number to test
bdfd12f
@cmontecoding
📚 update RPC url and --ir-minimum in package.json
7113902
@cmontecoding
✅ add --ir-minimum to coverage in ci
c3d4131
@cmontecoding
✅🗑️ remove BASE params from bootstrap
e58e0e5
@Flocqst
✅ Fix paydebt with new account setup
0d0bbe5
@cmontecoding
✅ update MulticallerWithSenderTest with new deployment
52f5d76
@cmontecoding
📚 replace base with arbitrum in foundry.toml
2ac440e
@cmontecoding
📚 add --etherscan-api-key to coverage.yml
68b101d
@cmontecoding
📚 add CODECOV_TOKEN to coverage.yml
94a53eb
@Flocqst
✅ unwind setup
639c1e9
@Flocqst
⚙ update foundry config
2eee6c8
@cmontecoding
✨ fmt
2a378b1
@Flocqst
✅ custom:todo OracleDataRequired error
fc785d7
@Flocqst Flocqst merged commit 73ffbef into arbitrum-release Oct 25, 2024
3 checks passed
@Flocqst Flocqst deleted the arbitrum-release-zap branch October 25, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmontecoding cmontecoding cmontecoding left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Flocqst @cmontecoding @jcmonte