Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔮 Remove Pyth Oracle Query #32

Merged
merged 18 commits into from
Dec 14, 2023
Merged

Conversation

JaredBorders
Copy link
Contributor

@JaredBorders JaredBorders commented Dec 12, 2023

Resolves two audit findings && bumps Engine.sol lcov to 100%

See here: https://gist.github.com/JaredBorders/af550fc3cdd982c9e9e2384089bab0f1

@JaredBorders JaredBorders self-assigned this Dec 12, 2023
@JaredBorders JaredBorders changed the base branch from main to add-batching December 12, 2023 18:38
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ed0504) 68.87% compared to head (a4296da) 70.91%.
Report is 1 commits behind head on add-batching.

Additional details and impacted files
@@               Coverage Diff                @@
##           add-batching      #32      +/-   ##
================================================
+ Coverage         68.87%   70.91%   +2.04%     
================================================
  Files                 7        7              
  Lines               196      196              
  Branches             38       38              
================================================
+ Hits                135      139       +4     
+ Misses               55       51       -4     
  Partials              6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaredBorders JaredBorders marked this pull request as ready for review December 12, 2023 19:04
@JaredBorders JaredBorders merged commit 2227ddb into add-batching Dec 14, 2023
6 checks passed
@JaredBorders JaredBorders deleted the L-05-Price-Condition branch January 5, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants