Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔎 [N-09] Unused Code #30

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

JaredBorders
Copy link
Contributor

@JaredBorders JaredBorders commented Dec 6, 2023

Response to External Guhu Audit

Audit: https://gist.github.com/guhu95/d1214b942ef0dfd5672f3a3167a231d1

On-going Response: https://gist.github.com/JaredBorders/5611450065734074ee6a7add8332df7b

Issues Remedied

[N-09] Unused Code

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a175ec7) 62.13% compared to head (d58bba2) 63.25%.

Additional details and impacted files
@@                Coverage Diff                @@
##           L-08-Auth-Fix      #30      +/-   ##
=================================================
+ Coverage          62.13%   63.25%   +1.12%     
=================================================
  Files                  6        6              
  Lines                169      166       -3     
  Branches              36       35       -1     
=================================================
  Hits                 105      105              
+ Misses                58       55       -3     
  Partials               6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaredBorders JaredBorders changed the title N 09 unused code ☂️ [N-09] Unused Code Dec 6, 2023
@JaredBorders JaredBorders self-assigned this Dec 6, 2023
@JaredBorders JaredBorders changed the title ☂️ [N-09] Unused Code 🔎 [N-09] Unused Code Dec 6, 2023
@JaredBorders JaredBorders changed the base branch from L-08-Auth-Fix to N-08-Unnecessary-Cast December 6, 2023 06:54
@JaredBorders JaredBorders merged commit a4076e8 into N-08-Unnecessary-Cast Dec 7, 2023
6 checks passed
@JaredBorders JaredBorders deleted the N-09-Unused-Code branch January 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants