Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏅 0xMacro Audit 10 Response #21

Merged
merged 4 commits into from
Dec 1, 2023
Merged

🏅 0xMacro Audit 10 Response #21

merged 4 commits into from
Dec 1, 2023

Conversation

JaredBorders
Copy link
Contributor

@JaredBorders JaredBorders marked this pull request as ready for review November 29, 2023 20:00
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ccd1d8) 74.10% compared to head (21d0249) 74.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   74.10%   74.46%   +0.36%     
==========================================
  Files           5        5              
  Lines         139      141       +2     
  Branches       28       29       +1     
==========================================
+ Hits          103      105       +2     
  Misses         30       30              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tommyrharper tommyrharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good change with the AccountDoesNotExist error. Might save someone some money.

@JaredBorders JaredBorders merged commit f6f8291 into main Dec 1, 2023
6 checks passed
@JaredBorders JaredBorders deleted the 0xMacro-Audit-10 branch January 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants