Update encoding type #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-encoding #17 +/- ##
=================================================
- Coverage 74.10% 59.71% -14.39%
=================================================
Files 5 5
Lines 139 139
Branches 28 28
=================================================
- Hits 103 83 -20
- Misses 30 49 +19
- Partials 6 7 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the value was changed from array of bytes to hash of bytes32 maybe the encoding type also needs to be updated inline with that?
Related change: https://github.com/Kwenta/smart-margin-v3/pull/15/files#diff-45daff05a689f1e9fb67189b7f9aaed1cd4aa0d207c56401cda7c7d99a13a9c0R69