Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ $USDC Zap #14

Closed
wants to merge 8 commits into from
Closed

⚡️ $USDC Zap #14

wants to merge 8 commits into from

Conversation

JaredBorders
Copy link
Contributor

Implement $USDC zap utility for the SMv3 Engine

Description

  • Create zap()
  • Test zap() ($USDC <-> $sUSD)
  • Update interfaces
  • Update Engine.constructor() with $USDC address
  • Move test environment to newer block number on Base Goerli

Related issue(s)

N/A

Motivation and Context

$USDC zap function improves UX for FE Andromeda support

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (d684448) 75.73% compared to head (864c20a) 64.77%.

❗ Current head 864c20a differs from pull request most recent head e2f7f46. Consider uploading reports for the commit e2f7f46 to get more accurate results

Files Patch % Lines
src/Engine.sol 0.00% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
- Coverage   75.73%   64.77%   -10.96%     
===========================================
  Files           5        5               
  Lines         136      159       +23     
  Branches       28       33        +5     
===========================================
  Hits          103      103               
- Misses         27       50       +23     
  Partials        6        6               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaredBorders JaredBorders deleted the usdc-zap branch January 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant