Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonce type fix #11

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Nonce type fix #11

merged 5 commits into from
Oct 25, 2023

Conversation

JaredBorders
Copy link
Contributor

fix nonce type in typehash.
improve test via fuzzing the nonce.
deploy new versions to testnet (OP Goerli and Base Goerli)

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #11 (fe9aea6) into main (6c07465) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   75.73%   75.73%           
=======================================
  Files           5        5           
  Lines         136      136           
  Branches       28       28           
=======================================
  Hits          103      103           
  Misses         27       27           
  Partials        6        6           
Files Coverage Δ
src/libraries/ConditionalOrderHashLib.sol 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JaredBorders JaredBorders merged commit db65363 into main Oct 25, 2023
5 checks passed
@JaredBorders JaredBorders deleted the nonce-type-fix branch October 25, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants