generated from Kwenta/foundry-scaffold
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💰 Conditional Order Fee Rework #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 72.86% 75.73% +2.86%
==========================================
Files 5 5
Lines 129 136 +7
Branches 26 28 +2
==========================================
+ Hits 94 103 +9
+ Misses 28 27 -1
+ Partials 7 6 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jcmonte
reviewed
Oct 18, 2023
jcmonte
reviewed
Oct 18, 2023
jcmonte
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how a fee is calculated and imposed. Introduce a new field to conditional order defining object that represents a max fee that an account is willing to pay for conditional order execution. Change fee to be denominated in ETH. Add
Description
ConditionalOrder
:maxExecutorFee
Engine.depositEth
,Engine.withdrawEth
,Engine._withdrawEth
EthDeposit
,EthWithdraw
InsufficientEthBalance
,EthTransferFailed
Engine.execute
andEngine.canExecute
to include afee
paramEngine.canExecute
logic to better predict whether an order can be executed (takes into consideration conditional order fees)Related issue(s)
N/A
Motivation and Context
Improve UX for traders and ensure more precise fees per order executed