👷 use withdrawTo for withdrawCollateralETH

Kwenta · Oct 1, 2024 · 90d9cc5 · 90d9cc5
1 parent 85ee168
commit 90d9cc5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Engine.sol b/src/Engine.sol
@@ -480,27 +480,26 @@ contract Engine is
         int256 _amount,
         uint256 _tolerance
     ) external override {
-        if (_amount >= 0) revert InvalidWithdrawalAmount();
+        if (_amount <= 0) revert InvalidWithdrawalAmount();
         if (!isAccountOwner(_accountId, msg.sender)) revert Unauthorized();
 
         PERPS_MARKET_PROXY.modifyCollateral(
-            _accountId, WETH_SYNTH_MARKET_ID, _amount
+            _accountId, WETH_SYNTH_MARKET_ID, -_amount
         );
 
         IERC20 synth = IERC20(SPOT_MARKET_PROXY.getSynth(WETH_SYNTH_MARKET_ID));
-        synth.approve(address(zap), _amount.abs256());
+        synth.approve(address(zap), uint256(_amount));
 
         uint256 unwrappedWETH = zap.unwrap(
             address(WETH),
             WETH_SYNTH_MARKET_ID,
-            _amount.abs256(),
+            uint256(_amount),
             _tolerance,
             address(this)
         );
 
         // Convert WETH to ETH and send to user
-        WETH.withdraw(unwrappedWETH);
-        payable(msg.sender).transfer(unwrappedWETH);
+        WETH.withdrawTo(msg.sender, unwrappedWETH);
     }
 
     function _depositCollateral(

diff --git a/src/interfaces/tokens/IWETH.sol b/src/interfaces/tokens/IWETH.sol
@@ -4,6 +4,7 @@ pragma solidity 0.8.20;
 interface IWETH {
     function deposit() external payable;
     function withdraw(uint256) external;
+    function withdrawTo(address recipient, uint256 amount) external;
     function approve(address guy, uint256 wad) external returns (bool);
     function transfer(address dst, uint256 wad) external returns (bool);
     function transferFrom(address src, address dst, uint256 wad)