👷🏻‍♂️ EIP7412 Fix

[JaredBorders]

Summary

Use the EIP7412 selector for fulfillOracleQuery and not the IERC7412 selector.

Concerns

Given

function fulfillOracleQuery(
    address EIP7412Implementer,
    bytes calldata signedOffchainData
) external payable {
    IERC7412(EIP7412Implementer).fulfillOracleQuery(signedOffchainData);
}

With EIP7412Implementer being variable, does this present a risk?

[tommyrharper]

As discussed on call, we decided to not allow users to execute fulfillOracleQuery with an arbitrary EIP7412Implementer address to avoid the possibility of a malicious actor who gains access to a biconomy EOA wallet private key being able to make a reentrant attack on Smart Margin V3 - despite the fact that Smart Margin V3 is in theory reentrant secure.

We decided this based on the principle of erring on the side of paranoia in security related decisions.

Instead we can define the EIP7412Implementer address as immutable at the smart contract engine level, and provide a different address for the different engines on different chains.

This removes the potential (though extremely unlikely) reentrant attack vector.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (389b804) 47.91% compared to head (0b6bc82) 50.00%.

Files	Patch %	Lines
src/kwenta/smv3/EIP7412.sol	0.00%	1 Missing ⚠️
test/SMv3SessionValidationModule.t.sol	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   47.91%   50.00%   +2.08%     
==========================================
  Files           9       10       +1     
  Lines         192      186       -6     
  Branches       24       20       -4     
==========================================
+ Hits           92       93       +1     
+ Misses         96       89       -7     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tommyrharper]

LGTM 👍 - as long as we are happy that SMv3 is reentrant secure