⏳ Early Enhancement & Pre-Audit Release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredBorders
changed the title
|
@insulineru tagging you just for visibility. you may be interested in the optimizations, etc |
jcmonte
reviewed
Oct 18, 2023
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
JaredBorders
requested review from
jcmonte and
tommyrharper
and removed request for
tommyrharper
jcmonte
approved these changes
Oct 19, 2023
| * @param _funcCallData the data for the call. is parsed inside the SVM | ||
| * @param _sessionKeyData SessionKey data, that describes sessionKey permissions | ||
| */ | ||
| function validateSessionParams( | ||
| address destinationContract, | ||
| uint256 callValue, | ||
| uint256, /*callValue*/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two validated function selectors to the SMv3 module and drastically improved testing.
Deployed pre-audit, optimized validation modules to OP, OP Goerli, Base, and Base Goerli.
Description
SMv3SessionValidationModule:depositEth,withdrawEthRelated issue(s)
N/A
Motivation and Context
Deploy early version for internal testing on mainnet 😮💨 (and add/improve things already discovered internally that will surely be addressed by the auditors)