Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradeability #1

Merged
merged 20 commits into from
Sep 13, 2024
Merged

Upgradeability #1

merged 20 commits into from
Sep 13, 2024

Conversation

Flocqst
Copy link
Contributor

@Flocqst Flocqst commented Jun 12, 2024

Make KSXVault UUPSUpgradeable

Description

  • Used OpenZeppelin UUPSUpgradeable pattern
  • Vault is only upgradeable by pDAO address (can be set to 0 to make contract non upgradeable)

Motivation and Context

https://github.com/Kwenta/kwenta-state-log/blob/master/kips/kip-123.md

$KSX will be upgradable to allow future changes to the staking strategy and composition of the backing tokens.

Copy link

Import ERC-4626 from OZ

@Flocqst Flocqst marked this pull request as ready for review June 24, 2024 17:38
@Flocqst Flocqst requested a review from jcmonte June 24, 2024 17:39
script/Deploy.s.sol Outdated Show resolved Hide resolved
src/KSXVault.sol Show resolved Hide resolved
test/Upgrade.t.sol Outdated Show resolved Hide resolved
@jcmonte jcmonte requested a review from JaredBorders June 24, 2024 17:52
@jcmonte
Copy link

jcmonte commented Jun 24, 2024

@JaredBorders Can I get your seasoned review here - context is KSX vault and adding upgradeability

@Flocqst Flocqst requested a review from jcmonte September 3, 2024 15:33
test/Upgrade.t.sol Show resolved Hide resolved
src/KSXVault.sol Show resolved Hide resolved
@Flocqst Flocqst requested a review from jcmonte September 11, 2024 13:29
@Flocqst Flocqst merged commit 15cfe3c into main Sep 13, 2024
1 of 3 checks passed
@Flocqst Flocqst deleted the upgradeable branch September 13, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants