Patches: tasklogger log_x
, randomized_svd
arguments, deprecated graph_shortest_path
#62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day,
This PR began its life to fix the issues with randomized svd discussed in #58. To fix that, I monkey patched in a version of randomized svd using
mock
that respects arguments passed in thedataclass
bipca.base.PCAParameters
. The patch works on all versions of sklearn, though it raises a warning to the user to let the maintainers ofgraphtools
know that sklearn has been updated when the version exceeds the current version.The
PCAParameters
dataclass has been documented and thepca_params
kwarg tographtools.base.Data
has been documented.I also made some small changes that made the tests run smoothly. I changed all calls to
tasklogger.debug
,.task
,.info
to their newlog_x
version. I changed instances ofsklearn.utils.graph_shortest_path.graph_shortest_path
toscipy.sparse.csgraph.shortest_path
, reflecting the fact that the former has been deprecated.The monkey patch required changing the way that SVD is done in the tests to make things line up properly. I fixed this in
test_exact.test_truncated_exact_graph_sparse
andtest_knn.test_knn_graph_sparse
.This build currently fails two tests reliably, as documented in #60. This can be fixed pretty quickly using the suggested changes in that issue.
This build intermittently fails
test_exact.test_shortest_path_affinity
as discussed in #61. I believemaster
fails this as well.