Merge pull request #2303 from Kozea/fix-2302

Set alpha even when current color channels didn’t change

tests/draw/test_opacity.py

@@ -58,3 +58,12 @@ def test_opacity_percent_clamp_up(assert_same_renderings):
         opacity_source % '<div></div><div style="opacity: -0.2"></div>',
         opacity_source % '<div></div><div style="opacity: -20%"></div>',
     )
+
+
+@assert_no_logs
+def test_opacity_black(assert_same_renderings):
+    # Regression test for https://github.com/Kozea/WeasyPrint/issues/2302
+    assert_same_renderings(
+        opacity_source % 'a<span style="color: rgb(0, 0, 0, 0.5)">b</span>',
+        opacity_source % 'a<span style="opacity: 0.5">b</span>',
+    )

weasyprint/pdf/stream.py

@@ -81,6 +81,8 @@ def end_text(self):
 
     def set_color(self, color, stroke=False):
         *channels, alpha = color
+        self.set_alpha(alpha, stroke)
+
         if stroke:
             if (color.space, *channels) == self._current_color_stroke:
                 return
@@ -105,7 +107,6 @@ def set_color(self, color, stroke=False):
         else:
             LOGGER.warn('Unsupported color space %s, use sRGB instead', color.space)
             self.set_color_rgb(*channels, stroke)
-        self.set_alpha(alpha, stroke)
 
     def set_font_size(self, font, size):
         if (font, size) == self._current_font: