Add new source + Tweak #1174
Merged
Add new source + Tweak #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koitharu
reviewed
Oct 17, 2024
| val doc = webClient.httpGet(fullUrl).parseHtml() | ||
|
|
||
| val script = doc.selectFirst("script:containsData(const CHAPTER_ID)")?.data() | ||
| ?: throw Exception("Failed to get chapter id") |
There was a problem hiding this comment.
Do not use generic Exception class
Comment on lines
20
to
21
| val script = doc.selectFirst("script:containsData(const CHAPTER_ID)")?.data() | ||
| ?: throw Exception("Failed to get chapter id") |
There was a problem hiding this comment.
Suggested change
| val script = doc.selectFirst("script:containsData(const CHAPTER_ID)")?.data() | |
| ?: throw Exception("Failed to get chapter id") | |
| val script = doc.selectFirstOrThrow("script:containsData(const CHAPTER_ID)")?.data() |
| val responseJson = webClient.httpGet(ajaxUrl).parseJson() | ||
|
|
||
| if (!responseJson.optBoolean("status", false)) { | ||
| throw Exception(responseJson.optString("msg")) |
There was a problem hiding this comment.
Suggested change
| throw Exception(responseJson.optString("msg")) | |
| throw IllegalStateException(responseJson.optString("msg")) |
| return manga.copy( | ||
| altTitle = doc.selectFirst("h2.other-name")?.text(), | ||
| author = doc.selectFirst("div.summary-heading:contains(Tác giả) + div.summary-content")?.text(), | ||
| tags = doc.select("div.genres-content a[rel=tag]").mapNotNullToSet { a -> |
There was a problem hiding this comment.
Suggested change
| tags = doc.select("div.genres-content a[rel=tag]").mapNotNullToSet { a -> | |
| tags = doc.select("div.genres-content a[rel=tag]").mapToSet { a -> |
| tags = doc.select("div.genres-content a[rel=tag]").mapNotNullToSet { a -> | ||
| MangaTag( | ||
| key = a.attr("href").substringAfterLast("/"), | ||
| title = a.text(), |
There was a problem hiding this comment.
Suggested change
| title = a.text(), | |
| title = a.text().toTitleCase(sourceLocale), |
| author = doc.selectFirst("div.summary-heading:contains(Tác giả) + div.summary-content")?.text(), | ||
| tags = doc.select("div.genres-content a[rel=tag]").mapNotNullToSet { a -> | ||
| MangaTag( | ||
| key = a.attr("href").substringAfterLast("/"), |
There was a problem hiding this comment.
Suggested change
| key = a.attr("href").substringAfterLast("/"), | |
| key = a.attr("href").substringAfterLast('/'), |
| return tagsCache.get() ?: run { | ||
| val tags = webClient.httpGet("https://$domain/genre").parseHtml() | ||
| .select("ul.page-genres li a") | ||
| .mapNotNullToSet { a -> |
There was a problem hiding this comment.
Suggested change
| .mapNotNullToSet { a -> | |
| .mapToSet { a -> |
| val tags = webClient.httpGet("https://$domain/genre").parseHtml() | ||
| .select("ul.page-genres li a") | ||
| .mapNotNullToSet { a -> | ||
| val title = a.ownText().trim() |
There was a problem hiding this comment.
Suggested change
| val title = a.ownText().trim() | |
| val title = a.ownText().toTitleCase(sourceLocale) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SayHentai (#1172), tweak DocTruyen5s and update sources domain