-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 花を包装する機能の追加とLambda設定の更新 #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
エラーハンドリングを入れてました Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Kota8102
reviewed
Jan 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
例外処理を日本語or英語に統一した方がいいかな?
Kota8102
approved these changes
Jan 3, 2025
Kota8102
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
概要
花を包み紙に包んでユーザに見せる機能を追加しました。。
変更点
影響範囲
diary_crate.pyとフロントでのAPI呼び出し部分。
テスト
このセクションでは、この PR に関連するテストケースやテスト方法を記載してください。
関連 Issue
PR Type
Enhancement
Description
flower_wrap
関数を追加し、指定されたflower_id
の花をランダムな包装紙で包んだ画像を生成する機能を実装しました。Changes walkthrough 📝
diary.ts
Lambda関数のバンドリング設定の追加
src/backend/lib/constructs/diary.ts
flower.ts
花画像選択用Lambda関数の修正
src/backend/lib/constructs/flower.ts
diary_create.py
画像合成機能の追加と不要関数の削除
src/backend/lambda/diary_create/diary_create.py
flower_wrap
を追加test_diary_create.py
`flower_wrap`関数のテスト追加
src/backend/test/pytest/test_diary_create.py
flower_wrap
関数のテストを追加requirements.txt
依存関係にPillowを追加
requirements.txt
Pillow
ライブラリを追加requirements.txt
diary_create用の依存関係追加
src/backend/lambda/diary_create/requirements.txt
Pillow
ライブラリを追加