Skip to content

Commit

Permalink
Feature/#215 (#216)
Browse files Browse the repository at this point in the history
## 概要

#190のデプロイエラーを解消するためにbackend.ymlの更新とスナップショットの更新を行いました。
参考 https://github.com/Kota8102/diary-app/actions/runs/11666241532

## 変更点

このセクションでは、具体的な変更点や修正箇所を箇条書きでリストアップしてください。

- backend.yml Checkoutのバージョンアップとfetch-depthの追加
- スナップショットを更新

## 影響範囲

Checkout時にリポジトリの全てのコミット履歴を取得するため、Checkoutにかかる負荷が高まる可能性がある

## テスト

このセクションでは、この PR に関連するテストケースやテスト方法を記載してください。

- ブランチにプッシュした際のデプロイがエラーなく完了すること。

## 関連 Issue

- 関連 Issue: #190
  • Loading branch information
AsukaNamiki authored Nov 5, 2024
2 parents d8b3c6e + 579ada4 commit f260216
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:
contents: read
steps:
- name: Checkout
uses: actions/checkout@v1
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v5
Expand Down
46 changes: 42 additions & 4 deletions src/backend/test/__snapshots__/snapshot.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,7 @@ exports[`Snapshot test 1`] = `
"Type": "AWS::IAM::Role",
"UpdateReplacePolicy": "Delete",
},
"ApiDiaryApiDeploymentCA0DCBF58f371befc63a0cdfb03ea0f02a044439": {
"ApiDiaryApiDeploymentCA0DCBF5956716ca5633216b3423fc72b0cb864b": {
"DependsOn": [
"ApiDiaryApibouquetGET7AC93032",
"ApiDiaryApibouquet8BAEBF58",
Expand Down Expand Up @@ -356,7 +355,7 @@ exports[`Snapshot test 1`] = `
"Format": "{"requestId":"$context.requestId","ip":"$context.identity.sourceIp","user":"$context.identity.user","caller":"$context.identity.caller","requestTime":"$context.requestTime","httpMethod":"$context.httpMethod","resourcePath":"$context.resourcePath","status":"$context.status","protocol":"$context.protocol","responseLength":"$context.responseLength"}",
},
"DeploymentId": {
"Ref": "ApiDiaryApiDeploymentCA0DCBF58f371befc63a0cdfb03ea0f02a044439",
"Ref": "ApiDiaryApiDeploymentCA0DCBF5956716ca5633216b3423fc72b0cb864b",
},
"MethodSettings": [
{
Expand Down Expand Up @@ -1376,7 +1375,46 @@ exports[`Snapshot test 1`] = `
},
"Type": "AWS::Lambda::Permission",
},
"ApiDiaryApititleOPTIONSCB7538FB": {
"Properties": {
"AuthorizationType": "NONE",
"HttpMethod": "OPTIONS",
"Integration": {
"IntegrationResponses": [
{
"ResponseParameters": {
"method.response.header.Access-Control-Allow-Headers": "'Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token'",
"method.response.header.Access-Control-Allow-Methods": "'OPTIONS,GET,POST,PUT,DELETE'",
"method.response.header.Access-Control-Allow-Origin": "'*'",
},
"StatusCode": "200",
},
],
"PassthroughBehavior": "NEVER",
"RequestTemplates": {
"application/json": "{"statusCode": 200}",
},
"Type": "MOCK",
},
"MethodResponses": [
{
"ResponseParameters": {
"method.response.header.Access-Control-Allow-Headers": true,
"method.response.header.Access-Control-Allow-Methods": true,
"method.response.header.Access-Control-Allow-Origin": true,
},
"StatusCode": "200",
},
],
"ResourceId": {
"Ref": "ApiDiaryApititle5FEB75D0",
},
"RestApiId": {
"Ref": "ApiDiaryApi1E03348A",
},
},
"Type": "AWS::ApiGateway::Method",
},
"ApiDiaryApivalidator04323B87": {
"Properties": {
"Name": "ValidateQueryString",
Expand Down

0 comments on commit f260216

Please sign in to comment.