Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive healthcheck support is similar to nginx's fail_timeout #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vislee
Copy link

@vislee vislee commented Aug 12, 2021

Like me reported issue #77 .
When only passive healthchecks are used, unhealthy nodes should have a time duration for failure.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2021

CLA assistant check
All committers have signed the CLA.

@Tieske
Copy link
Member

Tieske commented Aug 16, 2021

Since we have passive and active healthchecks, I think a user can already configure an active healthcheck instead of using a fail_timeout. Set the unhealthy interval in checks.active.unhealthy.interval.

@vislee This covers the usecase no?

@vislee
Copy link
Author

vislee commented Aug 16, 2021

Since we have passive and active healthchecks, I think a user can already configure an active healthcheck instead of using a fail_timeout. Set the unhealthy interval in checks.active.unhealthy.interval.

@vislee This covers the usecase no?

@Tieske Thank you for your answers.
This configuration checks.active.unhealthy.interval can bring healthy nodes online in time.
But, In ​cloud API gateway, some test domain name nodes are down for a long time.

@Tieske
Copy link
Member

Tieske commented Aug 17, 2021

@vislee sorry I didn't get your remark;

But, In ​cloud API gateway, some test domain name nodes are down for a long time.

Can you elaborate on this? what is the issue here?

@vislee
Copy link
Author

vislee commented Aug 17, 2021

@vislee sorry I didn't get your remark;

But, In ​cloud API gateway, some test domain name nodes are down for a long time.

Can you elaborate on this? what is the issue here?

@Tieske Sorry, I didn't make it clear.
In ​cloud API gateway, lots of test domain nodes are down for a long time.
This unhealth nodes will cause the active healthcheck to send a request every checks.active.unhealthy.interval to check the node to be healthy (I read the code is this, hope I understand is right), These requests are redundant in actual scenarios.
So, this test domain, passive healthcheck like nginx are enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants