-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): test with lua-resty-events 0.2.1 and OpenResty 1.25.3.1 #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment below, approved.
Some ideas: perhaps we should add the versions of lua-resty-events library to test matrix, not only for one tag. |
@chronolaw Just FYI we're using lua-resty-healthcheck 1.6.x for gateway 3.4/3.5 and 3.0.x for gateway >=3.6. So we might want to test that against |
If this PR is merged I will back port it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it later as this workflow doesn't run frequently, but we're probably good to stop testing with OpenResty 1.19.9.1.
lua-resty-events has upgraded to 0.2.1, we should test this library with latest version.
https://github.com/Kong/lua-resty-events/releases/tag/0.2.1
KAG-4605