Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): test with lua-resty-events 0.2.1 and OpenResty 1.25.3.1 #160

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented May 29, 2024

lua-resty-events has upgraded to 0.2.1, we should test this library with latest version.

https://github.com/Kong/lua-resty-events/releases/tag/0.2.1

KAG-4605

@chronolaw chronolaw marked this pull request as ready for review May 29, 2024 01:08
@chronolaw chronolaw requested a review from nowNick May 29, 2024 01:08
bungle
bungle previously approved these changes May 29, 2024
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment below, approved.

.github/workflows/build_and_test_with_resty_events.yml Outdated Show resolved Hide resolved
@chronolaw
Copy link
Contributor Author

chronolaw commented May 29, 2024

Some ideas: perhaps we should add the versions of lua-resty-events library to test matrix, not only for one tag.
But I am not github action expert.

@windmgc
Copy link
Member

windmgc commented May 29, 2024

@chronolaw Just FYI we're using lua-resty-healthcheck 1.6.x for gateway 3.4/3.5 and 3.0.x for gateway >=3.6. So we might want to test that against release/1.6.x as well

@chronolaw
Copy link
Contributor Author

@chronolaw Just FYI we're using lua-resty-healthcheck 1.6.x for gateway 3.4/3.5 and 3.0.x for gateway >=3.6. So we might want to test that against release/1.6.x as well

If this PR is merged I will back port it.

Copy link
Contributor

@locao locao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it later as this workflow doesn't run frequently, but we're probably good to stop testing with OpenResty 1.19.9.1.

@locao locao merged commit 128d8ec into master Jun 5, 2024
6 checks passed
@chronolaw chronolaw deleted the chore/test_resty_events_021 branch June 5, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants