Skip to content

Commit

Permalink
feat(lib): remove stupid version check from resty.events
Browse files Browse the repository at this point in the history
  • Loading branch information
bungle committed Jun 19, 2024
1 parent 830ae32 commit 96342f3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_with_resty_events.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
openresty-version: [1.19.9.1, 1.21.4.1, 1.21.4.3, 1.25.3.1]
openresty-version: [1.19.9.1, 1.21.4.3, 1.25.3.1]

steps:
- name: Update and install OS dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_with_worker_events.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
openresty-version: [1.21.4.1]
openresty-version: [1.21.4.3]

steps:
- name: Update and install OS dependencies
Expand Down
3 changes: 0 additions & 3 deletions lib/resty/healthcheck.lua
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ local type = type
local assert = assert


local RESTY_EVENTS_VER = [[^0\.[12]\.\d+$]]
local RESTY_WORKER_EVENTS_VER = "0.3.3"


Expand Down Expand Up @@ -113,8 +112,6 @@ local function load_events_module(self)

elseif self.events_module == "resty.events" then
worker_events = require("resty.events.compat")
local version_match = ngx.re.match(worker_events._VERSION, RESTY_EVENTS_VER, "o")
assert(version_match, "unsupported lua-resty-events version")

else
error("unknown events module")
Expand Down

0 comments on commit 96342f3

Please sign in to comment.