Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert BackendTLSPolicies into service annotations #6753

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Dec 2, 2024

What this PR does / why we need it:

Which issue this PR fixes:

Part of #6631

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@mlavacca mlavacca force-pushed the backendtlspolicy-customize-services branch from 03b4d14 to 9d8d427 Compare December 2, 2024 17:06
@mlavacca mlavacca changed the title feat: convert BackendTLSPolicies into service anns feat: convert BackendTLSPolicies into service annotations Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 27.86885% with 44 lines in your changes missing coverage. Please review.

Project coverage is 53.9%. Comparing base (6533c42) to head (9d8d427).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/dataplane/translator/ingressrules.go 31.4% 24 Missing ⚠️
internal/annotations/annotations.go 0.0% 11 Missing ⚠️
internal/store/store.go 40.0% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #6753      +/-   ##
========================================
- Coverage   77.7%   53.9%   -23.9%     
========================================
  Files        206     205       -1     
  Lines      24302   24370      +68     
========================================
- Hits       18894   13145    -5749     
- Misses      4440   10137    +5697     
- Partials     968    1088     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant