-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(konnect): add namespace in KonnectNamespacedRef #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we've decided to not implement cross namespace references.
Kong/gateway-operator#524 for example has been put into 'post-GA' part of the epic.
Let's first solve the immediate scope from Kong/gateway-operator#370 (for October's release).
LMKWYT
|
Left a comment about this in https://kongstrong.slack.com/archives/C079GK3KB9R/p1726654138359599. IMHO we should prevent using cross-namespace refs until we implement proper handling of those. In order to move forward with Vaults, let's review and merge this but at the same time let's add CEL validation rules to other types that will prevent users from using cross namespace ref in non cluster scoped resources. |
26c51a5
to
3cfd80f
Compare
3cfd80f
to
fc27b30
Compare
What this PR does / why we need it:
Add
namespace
inkonnectNamespacedRef
because some of Kong entities likeKongVault
andKongClusterPlugin
are cluster scoped and they require the namespace for referring to a Konnect gateway controlplane.Which issue this PR fixes
#36
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes