-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): linting rules and fixes #233
Draft
adamdehaven
wants to merge
13
commits into
main
Choose a base branch
from
feat/lint-rules-remove-kongponents-utils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateslo
added
the
do not merge
Do not merge this pull request until this label is removed.
label
Sep 6, 2023
…rules-remove-kongponents-utils
…rules-remove-kongponents-utils
@adamdehaven can we close this PR? |
@nateslo if we're thinking none of this matters until 🤫 sure; your call 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
eslint
andstylelint
rules to block the usage of Kongponents utility classes and CSS custom properties in Portal (as they will be removed in the next release).TODO before merge
main
/.vscode/settings.json
fileyarn stylelint:fix
yarn lint:fix
@kong/kongponents
dependency to thealpha
release (yarn add @kong/kongponents@alpha
) once it is available (before merge)After steps above are completed, this PR also includes:
stylelint
and associated rules (e.g. property order, etc.)lint:fix
andstylelint:fix
to update the codebase to adhere to the new rules. Verified no breaking changes..client.eslintrc.js
and.eslintrc.js
files as there was no reason for them to be separatetypecheck
into the pre-commit hook to prevent code being pushed that we already know will fail the CIstylelint
check to the CI pipelines@kong/design-tokens
package and auto-injects the SCSS variables into all components to utilize as neededExisting codebases/forks/etc. can run the following commands to ensure their custom code adheres to the new rules:
# Get latest from main branch, then... yarn install --frozen-lockfile yarn stylelint:fix yarn lint:fix