Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ktabs): add data-testid to list items #2574

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

aanchalm01
Copy link
Contributor

@aanchalm01 aanchalm01 commented Jan 16, 2025

Summary

Addresses:
https://konghq.atlassian.net/browse/KHCP-14697

This PR adds data-testid attribute to "li" elements in KTabs to enhance traceability.

@aanchalm01 aanchalm01 self-assigned this Jan 16, 2025
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit a8f4d1b
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/678922c2eda4ec00082fd987
😎 Deploy Preview https://deploy-preview-2574--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit a8f4d1b
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/678922c285f2600008eb1d84
😎 Deploy Preview https://deploy-preview-2574--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aanchalm01 aanchalm01 enabled auto-merge (squash) January 16, 2025 15:20
@aanchalm01 aanchalm01 merged commit bf80d75 into main Jan 16, 2025
11 checks passed
@aanchalm01 aanchalm01 deleted the fix/khcp-14697-add-data-testid-KTabs branch January 16, 2025 15:22
kongponents-bot pushed a commit that referenced this pull request Jan 16, 2025
## [9.16.4](v9.16.3...v9.16.4) (2025-01-16)

### Bug Fixes

* **ktabs:** add data-testid to list items ([#2574](#2574)) ([bf80d75](bf80d75))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.16.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants