Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): helps forked repos work by default #47

Closed
wants to merge 1 commit into from

Conversation

rspurgeon
Copy link

This PR removes the license check workflow which is not necessary for "dependent" (forked or template invoked) repos. In addition this removes an assumption for a repo level setting that is kong specific.

@rspurgeon rspurgeon requested a review from mheap February 29, 2024 19:52
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Tieske
Copy link
Member

Tieske commented Mar 1, 2024

I moved the timeouts to #48 , the license check cannot be removed, would require an internal approved Jira ticket. Hence closing this.

@Tieske Tieske closed this Mar 1, 2024
@Tieske Tieske deleted the fix-timeouts branch March 1, 2024 08:47
@mheap
Copy link
Member

mheap commented Mar 1, 2024

@Tieske Core plugins are bundled in the Kong/kong repos now. Which plugins use the license checker action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants