Skip to content

Commit

Permalink
chore(deps-dev): bump @playwright/test from 1.48.2 to 1.49.0 (#332)
Browse files Browse the repository at this point in the history
* chore(deps-dev): bump @playwright/test from 1.48.2 to 1.49.0

Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.48.2 to 1.49.0.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.48.2...v1.49.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* test(*): wait for editor

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Leopoldthecoder <[email protected]>
  • Loading branch information
dependabot[bot] and Leopoldthecoder authored Nov 22, 2024
1 parent e5262a8 commit 981f5b8
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 14 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"devDependencies": {
"@kong/design-tokens": "^1.17.2",
"@kong/eslint-config-kong-ui": "^1.1.2",
"@playwright/test": "^1.48.2",
"@playwright/test": "^1.49.0",
"@types/lodash-es": "^4.17.12",
"@types/node": "^20.3.1",
"@vitejs/plugin-vue": "^5.1.3",
Expand Down
26 changes: 13 additions & 13 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tests/playwright/specs/routes-expressions/01-Routes.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ test.describe('route creation page', () => {

// the editor shows invalid because it is empty
await expect(page.locator('.expression-editor')).toHaveClass(/invalid/)
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -113,6 +114,7 @@ test.describe('route creation page', () => {
await page.locator('#expressions-tab').click()
// should not contain the paths field
await expect(configBlock).not.toContainText(/paths:/)
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -162,6 +164,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand All @@ -186,6 +189,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -213,6 +217,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down Expand Up @@ -245,6 +250,7 @@ test.describe('route creation page', () => {

// switch to the expressions tab
await page.locator('#expressions-tab').click()
await page.waitForSelector('.monaco-editor')

const editor = page.locator('.monaco-editor').first()

Expand Down

0 comments on commit 981f5b8

Please sign in to comment.