Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): notify user when reading from stdin #17

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 27, 2023

Only if stdin and stderr are both TTY. To inform users input is expected, instead of appearing to "hang".

related to Kong/deck#1115

@Tieske Tieske requested a review from a team November 27, 2023 14:59
Only if stdin and stderr are both TTY. To inform users input
is expected, instead of appearing to "hang".
@Tieske Tieske changed the base branch from main to deps/revert-color November 29, 2023 14:27
GGabriele
GGabriele previously approved these changes Nov 29, 2023
Base automatically changed from deps/revert-color to main November 29, 2023 14:35
@Tieske Tieske dismissed GGabriele’s stale review November 29, 2023 14:35

The base branch was changed.

@Tieske Tieske merged commit 4181f77 into main Nov 29, 2023
16 checks passed
@Tieske Tieske deleted the notify/stdin branch November 29, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants