Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): Switch to copyloopvar linter for Go 1.22+ #150

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mheap
Copy link
Member

@mheap mheap commented Nov 28, 2024

Summary

The exportloopref linter is no longer needed due to a change in how loop variables work in Go 1.22+

See https://go.dev/blog/loopvar-preview for more information

Full changelog

  • Replaced exportloopref with copyloopvar linter

The `exportloopref` linter is no longer needed due to a
change in how loop variables work in Go 1.22+

See https://go.dev/blog/loopvar-preview for more information
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.72%. Comparing base (ae3de6e) to head (e5670df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   28.77%   28.72%   -0.06%     
==========================================
  Files         106      106              
  Lines       15852    15814      -38     
==========================================
- Hits         4561     4542      -19     
+ Misses      10812    10793      -19     
  Partials      479      479              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mheap mheap merged commit d53b0d3 into main Nov 28, 2024
18 checks passed
@mheap mheap deleted the switch-to-copyloopvar branch November 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants