fix: updating Konnect auth logic to properly handle geo rewrites #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 28.50% 28.77% +0.26%
==========================================
Files 106 106
Lines 15851 15852 +1
==========================================
+ Hits 4519 4561 +42
+ Misses 10869 10812 -57
- Partials 463 479 +16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pmalek
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
This looks like it's solving the same problem as Kong/sdk-konnect-go@4f50eb7 for sdk-konnect-go.
BTW: I've just realized now that this project also contains manually maintained Konnect client. Created #147 to migrate off of it to using https://github.com/Kong/sdk-konnect-go/.
|
Thanks @pmalek! Please let me know once we're able to merge & tag this change. |
As Konnect's authorization service is not deployed across all regions, the global endpoint is used for certain API calls. When the organization info is fetched, the hostname within the provided base URL is then rewritten to the relevant global endpoint. This rewrite logic was unable to handle any number of geos, relying on hard coded logic instead for specific geos. This logic has been updated to allow callers of this library to talk to multiple geos; this includes new geos that may not exist as of this writing.
pmalek
force-pushed
the
fix/api-endpoint-geo-rewrite
branch
from
7601574 to
c4dfb8a
Compare
|
@tjasko merged and released now https://github.com/Kong/go-database-reconciler/releases/tag/v1.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As Konnect's authorization service is not deployed across all regions, the global endpoint is used for certain API calls. When the organization info is fetched, the hostname within the provided base URL is then rewritten to the relevant global endpoint.
This rewrite logic was unable to handle any number of geos, relying on hard coded logic instead for specific geos. This logic has been updated to allow callers of this library to talk to multiple geos; this includes new geos that may not exist as of this writing.
decK will also be updated to use this new change.
Full changelog
Issues resolved
N/A
Documentation
N/A
Testing