Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds paths information in 3.4.x compatibility warn #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khaikong
Copy link

Summary

When running deck diff on Kong 3.4.x we can see below error:

1 unsupported routes' paths format with Kong version 3.0
or above were detected. Some of these routes are (not an exhaustive list):

ecf1297e-95e2-4e86-9384-86c892f941a7

Please upgrade your configuration to account for 3.0
breaking changes using the following command:

As there are hundred of regex route and the error causing the pipeline to stop. There are no way currently to determine the problematic route.

There is a workaround for this issue by running deck convert but I would like to see the affected route first before running the command.

Full changelog

  • Add extra path information in 3.4.x compatibility warn

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@Prashansa-K
Copy link
Collaborator

@khaikong Could you rebase the branch with main and rectify the lint errors that CI is throwing?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.72%. Comparing base (d53b0d3) to head (0600c8a).

Files with missing lines Patch % Lines
pkg/file/builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   28.72%   28.72%           
=======================================
  Files         106      106           
  Lines       15814    15814           
=======================================
  Hits         4542     4542           
  Misses      10793    10793           
  Partials      479      479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khaikong
Copy link
Author

@Prashansa-K Done! Could you please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants