Adds a NoDeletes function to the Syncer #143
Open
+178
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 28.72% 28.70% -0.02%
==========================================
Files 106 106
Lines 15814 15822 +8
==========================================
Hits 4542 4542
- Misses 10793 10801 +8
Partials 479 479 ☔ View full report in Codecov by Sentry. |
If the Syncer is configured with noDeletes true, deleteDuplicates and delete operations are skipped entirely in the diff() function. Testing WIP
Prashansa-K
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the Syncer is configured with noDeletes true, deleteDuplicates and delete operations are skipped entirely in the diff() function.
Full changelog
Testing
Tests added using
diff.NewSyncer()as callingdeck gateway difffails. This function is for a new deck command, which will not be exposed viadeck gateway diffso updating deck doesn't make sense here