Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a NoDeletes function to the Syncer #143

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adds a NoDeletes function to the Syncer #143

wants to merge 3 commits into from

Conversation

rspurgeon
Copy link
Collaborator

@rspurgeon rspurgeon commented Sep 10, 2024

Summary

If the Syncer is configured with noDeletes true, deleteDuplicates and delete operations are skipped entirely in the diff() function.

Full changelog

  • Adds NoDeletes function to Syncer. Usage of this feature in decK will come in a subsequent change.

Testing

Tests added using diff.NewSyncer() as calling deck gateway diff fails. This function is for a new deck command, which will not be exposed via deck gateway diff so updating deck doesn't make sense here

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 28.70%. Comparing base (d53b0d3) to head (b2956fa).

Files with missing lines Patch % Lines
pkg/diff/diff.go 0.00% 13 Missing ⚠️
tests/integration/test_utils.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   28.72%   28.70%   -0.02%     
==========================================
  Files         106      106              
  Lines       15814    15822       +8     
==========================================
  Hits         4542     4542              
- Misses      10793    10801       +8     
  Partials      479      479              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If the Syncer is configured with noDeletes true, deleteDuplicates and delete operations
are skipped entirely in the diff() function.

Testing WIP
@mheap mheap marked this pull request as ready for review December 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants